cheran-senthil/PyRival

The new SortedList method naming scheme is not user friendly

heidenrei opened this issue · 3 comments

heidenrei commented

The old method names were better as they directly copied sortedcontainers. Using multiset method names is annoying.

bjorn-martinsson commented

Can you be more specific?

bogoconic1 commented

SortedList in python uses bisect_left (not lower_bound) and bisect_right (not upper_bound) and add method (not insert)
lower_bound and upper_bound is the method names for C++ and many python users arent very good at it, which makes it very confusing

lower_bound -> bisect_left
upper_bound -> bisect_right
insert -> add

ensure consistency between the main SortedList implementation and this implementation

  • 👍2
Mukundan314 commented

A remove method would be good as s.pop(s.lower_bound(val)) is not so obvious

  • 👍1