Improve name display for diff
Closed this issue · 3 comments
xlc commented
This is what I am getting currently
Running subwasm v0.12.0
🅰️ File("karura-1003.wasm")
🅱️ Chain(OnchainBlock { endpoint: WebSocket("wss://karura-rpc-2.aca-api.network/ws"), block_ref: None })
🅰️ 2.754 MB (2,887,358 bytes)
🅱️ 2.721 MB (2,853,554 bytes)
Checking metadata versions:
✅ Both metadata versions are identical: V13
Checking core versions:
❌ The 2 core versions are different:
🅰️ karura-1003 (karura-0.tx1.au1)
🅱️ karura-1002 (karura-0.tx1.au1)
Checking runtime metadata:
❌ The metadata are different
Comparing V13 with V13
🛠 modules.0.constants.4.value. "186B6172757261186B617275726101000000EB0300000000000034DF6ACB689907609B0300000037E397FC7C91F5E40100000040FE3AD401F8959A05000000D2BC9897EED08F1502000000F78B278BE53F454C02000000DD718D5CC53262D401000000AB3C0572291FEB8B01000000BC9D89904F5B923F0100000037C8BB1350A9A2A8010000006EF953004BA30E5901000000F485C9145D3F0AAD01000000E3DF3F2AA8A5CC5701000000EA93E3F16F3D69620100000001000000" --> "186B6172757261186B617275726101000000EA0300000000000034DF6ACB689907609B0300000037E397FC7C91F5E40100000040FE3AD401F8959A05000000D2BC9897EED08F1502000000F78B278BE53F454C02000000DD718D5CC53262D401000000AB3C0572291FEB8B01000000BC9D89904F5B923F0100000037C8BB1350A9A2A8010000006EF953004BA30E5901000000F485C9145D3F0AAD01000000E3DF3F2AA8A5CC5701000000EA93E3F16F3D69620100000001000000"
🗑 modules.10.constants.5. {"documentation":[" The polynomial that is applied in order to derive fee from weight."],"name":"WeightToFee","ty":"Vec<WeightToFeeCoefficient<PalletBalanceOf<T>>>","value":"0408000000000000000000000000000000000000000001"}
🛠 modules.11.constants.1.value. "005039278C0400000000000000000000" --> "00204AA9D10100000000000000000000"
🛠 modules.17.constants.1.value. "04000000" --> "05000000"
🛠 modules.36.constants.0.value. "201C0000" --> "00E10000"
🛠 modules.36.constants.1.value. "40380000" --> "E0C40000"
🛠 modules.36.constants.2.value. "40380000" --> "E0C40000"
🛠 modules.43.calls.4.arguments.0.name. "owner" --> "currency_id_a"
🛠 modules.43.calls.4.arguments.0.ty. "T::AccountId" --> "CurrencyId"
🛠 modules.43.calls.4.arguments.1.name. "currency_id_a" --> "currency_id_b"
🗑 modules.43.calls.4.arguments.2. {"name":"currency_id_b","ty":"CurrencyId"}
Changes:
- unmodified = 91.08% (143)
- added = 0.00% (0)
- modified = 7.01% (11)
- removed = 1.91% (3)
Skipped:
- documentation = 3
- bytes = 0
It will be better if modules.43.calls.4 can be translated to dex.add_provision
chevdor commented
I agree, this diff command need rework anyway.
chevdor commented
Closing this issue now as the version 0.20.0 is doing a much better job. Check both the diff and the new show commands.