Cannot inherit from non-open class 'CHTCollectionViewWaterfallLayout' outside of its defining module

Just changing access modifier from public to open would resolve the warning, but I'm not sure if that's the right thing to do. The current API design, in my point of view, is not suitable for subclassing; many implementations are kept private while several point of interest does not offer customization for subclasses.

So what's the problem you are trying to solve by inheriting from CHTCollectionViewWaterfallLayout?

Problem which I solve is moving settings code to separate class and dublication it on several app screens

…

On 12 Aug 2019, at 17:21, ApolloZhu ***@***.***> wrote: Just changing access modifier from public to open would resolve the warning, but I'm not sure if that's the right thing to do. The current API design, in my point of view, is not suitable for subclassing; many implementations are kept private while several point of interest does not offer customization for subclasses. So what's the problem you are trying to solve by inheriting from CHTCollectionViewWaterfallLayout? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Take a look at the project included in the Demo folder and see if you can implement this without subclassing the layout class?

CHTCollectionViewWaterfallLayout/Demo/Swift/CHTWaterfallSwiftDemo/ViewController.swift

Lines 44 to 55 in e453486

    
           let layout = CHTCollectionViewWaterfallLayout() 
        
           // Change individual layout attributes for the spacing between cells 
        
           layout.minimumColumnSpacing = 1.0 
        
           layout.minimumInteritemSpacing = 1.0 
        
           // Collection view attributes 
        
           collectionView.autoresizingMask = [.flexibleHeight, .flexibleWidth] 
        
           collectionView.alwaysBounceVertical = true 
        
           // Add the waterfall layout to your collection view 
        
           collectionView.collectionViewLayout = layout

	let layout = CHTCollectionViewWaterfallLayout()

	// Change individual layout attributes for the spacing between cells
	layout.minimumColumnSpacing = 1.0
	layout.minimumInteritemSpacing = 1.0

	// Collection view attributes
	collectionView.autoresizingMask = [.flexibleHeight, .flexibleWidth]
	collectionView.alwaysBounceVertical = true

	// Add the waterfall layout to your collection view
	collectionView.collectionViewLayout = layout