Support RTL in seeking Slider

Question

Support RTL in seeking Slider

MoElnaggar14 opened this issue 4 years ago · 13 comments

MoElnaggar14 commented 4 years ago

Describe the bug
seeking is scrolling in the opposite direction in RTL.

To Reproduce

Using RangUISlider in App Support RTL.

Expected behaviour
seeking should work from RTL for min and LTR for max.

Answer 1 · 2020-12-27T16:47:03.000Z

Hi @MoElnaggar14 , thank you for your feedback. I will work on this in the following days. I will let you know when a pull request is ready

In the meantime you can support my work by ⭐️ starring ⭐️ the repository.

Thanks,
Fabrizio.

Answer 2 · 2020-12-27T18:27:10.000Z

Hi @MoElnaggar14 ,

I'm here again to tell you that I implemented the feature you asked in this issue (it was quicker than I was expecting 😅). Can you test the code contained in the pull request below and try the new stuff to see if it works as you expect?

Add support for RTL (Closes #21) #22

After your confirmation, I will release a new version of RangeUISlider.

Thanks,
Fabrizio.

Answer 3 · 2020-12-27T18:39:11.000Z

Hello @chicio,
Thank you for the quick implementation for this feature.

cool, I'll test it today and back to you in #22

Thanks

Answer 4 · 2020-12-27T20:18:14.000Z

Screen.Recording.2020-12-27.at.10.15.35.PM.mov

I just tested the #22. Unfortunately, it's the same results

Answer 5 · 2020-12-28T07:55:00.000Z

Hi @MoElnaggar14 , sorry to hear that 😔. I think I misunderstood the problem. I will work on it today and I will let you know when I have something ready.

Answer 6 · 2020-12-28T09:51:39.000Z

Hi @MoElnaggar14 , I made the fix. If you test again the code in the pull request I sent you before you should get the expected behaviour. Attached here you can find also a video that show the demo project running in simulated RTL mode where RangeUISlider works as expected.

Screen.Recording.2020-12-28.at.10.48.18.mov

Answer 7 · 2020-12-28T09:54:14.000Z

Hi @chicio
I'll test it today. I really appreciate your quick response.

Thank,
Mohammed

Answer 8 · 2021-01-01T12:23:15.000Z

Hi @MoElnaggar14 and happy new year 🎊!! Did you have the time to try out the PR code with the new implementation?

Thanks,
Fabrizio.

Answer 9 · 2021-01-01T13:16:13.000Z

Happy new year @chicio , wishing you the best.

Absolutely, i'll do it today and keep you updated 🙏🏻

Answer 10 · 2021-01-02T13:02:24.000Z

@MoElnaggar14 Any news?

Answer 11 · 2021-01-02T13:08:47.000Z

Testing, just a sec

Answer 12 · 2021-01-02T13:19:25.000Z

Hi @chicio , sorry for the late test.

Awesome 👏looks good and works fine.

Answer 13 · 2021-01-02T13:21:17.000Z

Thank you @MoElnaggar14 🙏. I will prepare a new release in the afternoon 🚀🚀