/developer-task-01

Primary LanguageJava

Developer Task 1: Victor Chinyavada

chinyavadav@gmail.com

Issue 1: MobileNumberUtils LOGGER not static

MobileNumberUtils LOGGER not static hence it cannot be called from a static method

/Users/chinyavadav/Documents/zss/developer-task-01/econet-utils/src/main/java/com/econetwireless/utils/formatters/MobileNumberUtils.java:36:13
java: non-static variable LOGGER cannot be referenced from a static context

Issue 2: Log4j2 Misconfiguration

Log4j2 in the intelligent-network-api & electronic-payments-api has a misconfigured log path to save logs. The current path looks to save in the computer's root folder instead of classpath. Also there is no root logger defined for Log4j2

2021-03-27 13:12:43,859 main WARN No Root logger was configured, creating default ERROR-level Root logger with Console appender
2021-03-27 13:12:44,028 main ERROR Unable to create file /data/logs/intelligent-network-api/default/application.log java.io.IOException: No such file or directory
2021-03-27 13:16:24,531 main WARN No Root logger was configured, creating default ERROR-level Root logger with Console appender

Issue 3: COMPILATION ERROR: Cannot find PreInsert

PreInsert annotation cannot be found in com.econetwireless.epay.domain.SubscriberRequest

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/chinyavadav/Documents/zss/developer-task-01/electronic-payments-domain/src/main/java/com/econetwireless/epay/domain/SubscriberRequest.java:[42,6] cannot find symbol
  symbol:   class PreInsert
  location: class com.econetwireless.epay.domain.SubscriberRequest

Issue 4: Compilation failure: Compilation failure: wrong use of super && this keywords

this(super);

Issue 5: JPA persist & update methods not found

SubscriberRequestDao extends JPA repository which in turn has no method persist or update defined

Issue 6: Error Executing JPARepository method findByPartnerCode

Mismatching Entity name and reference in @NamedQuery

"select r from request r where r.partnerCode = :partnerCode order by r.dateCreated desc ")
13:53:40.216 [main] ERROR org.hibernate.internal.SessionFactoryImpl - HHH000177: Error in named query: SubscriberRequest.findByPartnerCode
           org.hibernate.hql.internal.ast.QuerySyntaxException: Request is not mapped [select r from Request r where r.partnerCode = :partnerCode order by r.dateCreated desc ]

Issue 7: NullPointerException in com.econetwireless.epay.api.rest.resources.EpayResource

TESTS failing because controller is throwing null pointer exception because controller parameter is declared as final and has no @PathVariable annotation

    public AirtimeBalanceResponse enquireAirtimeBalance( final String pCode, @PathVariable("mobileNumber") final String msisdn) {}
  shouldReturnStatusOkIfRequestsAreMoreThanOne(com.econetwireless.epay.api.rest.resources.EpayResourcesIT): Request processing failed; nested exception is java.lang.NullPointerException

Issue 8: private ResponseCode.getCode() returns null values

ResponseCode.getCode() returns null values because the enum field code is not assigned rather the parameter in constructor assigns to itself;

public enum ResponseCode {
    SUCCESS("200"), FAILED("500"), INVALID_REQUEST("400");
    private String code;
    private ResponseCode(String code) {
        code = code;
    }
    public String getCode() {
        return code;
    }
}

Issue 9: Controller without @Autowired service imports or constructor

EpayResource epayRequestProcessor && reportingProcessor interfaces are not autowired or instantiated via constructor

Issue 10: The server sent HTTP status code 415: Unsupported Media Type

Soap Service is getting different MediaType due to SOAP12HTTP_BINDING in IntelligentNetworkBinding

@BindingType(value = SOAPBinding.SOAP12HTTP_BINDING)
Could not access remote service at [http://localhost:8888/intelligent-network-api/IntelligentNetworkService]; nested exception is com.sun.xml.internal.ws.client.ClientTransportException: The server sent HTTP status code 415: Unsupported Media Type

Issue 11: partnerCode not found

Missing @WebParam(name = "partnerCode") annotation on partnerCode parameter in IntelligentNetworkService

Failed tests: airtimeBalanceEnquiryShouldReturnResponseCodeSUCCESSIfAllOtherSystemsAreUp(com.econetwireless.epay.api.rest.resources.EpayResourcesIT): JSON path "$.responseCode" expected:<200> but was:<400>

Results

mvn clean verify

mvn clean verify

mvn jetty:run

mvn jetty:run