chipmunk-sm/HexEditor

"make uninstall" deletes all the svg icons in "/usr/share/icons/hicolor/scalable/apps/"

trappedinspacetime opened this issue · 0 comments

Linux:
$ uname -m && cat /etc/*release

        x86_64
        DISTRIB_ID=Ubuntu
        DISTRIB_RELEASE=20.04
        DISTRIB_CODENAME=focal
        DISTRIB_DESCRIPTION="Ubuntu 20.04.3 LTS"
        NAME="Ubuntu"
        VERSION="20.04.3 LTS (Focal Fossa)"
        ID=ubuntu
        ID_LIKE=debian
        PRETTY_NAME="Ubuntu 20.04.3 LTS"
        VERSION_ID="20.04"
        HOME_URL="https://www.ubuntu.com/"
        SUPPORT_URL="https://help.ubuntu.com/"
        BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
        PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
        VERSION_CODENAME=focal
        UBUNTU_CODENAME=focal
  • Where did you get the program: PPA, or build from source?
    From source
  • Qt version
    Qt version 5.12.8
  • Expected & Actual results

sudo make uninstall removes all svg files in /usr/share/icons/hicolor/scalable/apps/

First of all, I congratulate you on your project. I like it.
The day before I cloned this repo and built it via qmake then make and I installed it with sudo make install.
When I noticed that it could be installable via a deb pakage, so I did sudo make uninstall, git clean -fxd then
dpkg-buildpackage -b -rfakeroot -us -uc and I installed deb package.
I noticed later that all svg files in /usr/share/icons/hicolor/scalable/apps/ got deleted.
At first I suspected of another application that I installed from source, but later I noticed that it's related to HexEditor's Makefile

I reproduced the issue, make uninstall wants to remove svg files:

      make uninstall 
      rm -f /usr/bin/hexeditor
      rm: cannot remove '/usr/bin/hexeditor': Permission denied
      make: [Makefile:794: uninstall_target] Error 1 (ignored)
      rmdir /usr/bin/ 
      rmdir: failed to remove '/usr/bin/': Permission denied
      make: [Makefile:795: uninstall_target] Error 1 (ignored)
      rm -f -r /usr/share/icons/hicolor/scalable
      rm: cannot remove '/usr/share/icons/hicolor/scalable/categories/slideshow-symbolic.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/emblems/slideshow-emblem.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/autokey-status-error.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.seahorse.Application.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/autokey-status-dark.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/gnome-disks-state-standby-symbolic.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/cellwriter.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.DejaDup.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.DiskUtility.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/autokey.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.Yelp.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.DiskUtility.Devel.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.Settings.Devel.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/session-properties.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/autokey-status.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.Cheese.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/preferences-ubuntu-panel-symbolic.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/tcpview.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/preferences-color.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.dfeet.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/preferences-system-time.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/preferences-desktop-display.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.Settings.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/org.gnome.DiskUtility-symbolic.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/pasystray.svg': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/scalable/apps/hexeditor.svg': Permission denied
      make: [Makefile:804: uninstall_hicolor] Error 1 (ignored)
      rm -f -r /usr/share/icons/hicolor/256x256
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/preferences-color.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/ubuntu-logo-icon.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/goa-panel.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/universal-cp.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/hexeditor_logo.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/gnome-power-manager.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/av-cp.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/preferences-system-time.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/network-light-256x256.png': Permission denied
      rm: cannot remove '/usr/share/icons/hicolor/256x256/apps/hexeditor.png': Permission denied
      make: [Makefile:805: uninstall_hicolor] Error 1 (ignored)
      rmdir /usr/share/icons/hicolor/ 
      rmdir: failed to remove '/usr/share/icons/hicolor/': Permission denied
      make: [Makefile:806: uninstall_hicolor] Error 1 (ignored)
      rm -f -r /usr/share/applications/hexeditor.desktop
      rm: cannot remove '/usr/share/applications/hexeditor.desktop': Permission denied
      make: [Makefile:814: uninstall_desktopentry] Error 1 (ignored)
      rmdir /usr/share/applications/ 
      rmdir: failed to remove '/usr/share/applications/': Permission denied
      make: [Makefile:815: uninstall_desktopentry] Error 1 (ignored)