Low-contrast in light mode makes text unreadable
Closed this issue · 12 comments
Choose seems to pick dark mode or light mode based on what's behind it on the screen (I guess?). Dark mode is OK, but light mode has low contrast between text and background for the non-selected items and I can barely read them.
I see there's a new 1.1 release but it's not on homebrew yet it seems so I can't easily test the new CLI options yet. I'm using 1.0 currently.
Note with 1.1 I still have this issue.
Also I submitted a pull request to homebrew-core to switch to the chipsenkbeil account and update to 1.1.
Beyond 1.1, in the work towards 1.2, I've started implementing different requests from the issue list. The first was changing some of the colors to better support dark and light modes. This landed with 66e0f51. Sounds like you haven't been able to try it yet to see if it resolves your issue.
Could we update the homebrew formula to support building from HEAD? I know that was a feature that used to exist in homebrew, but don't know if it's still there. That way, you could build more easily and try out new features that don't yet have a tag.
Thoughts?
It looks like I can get a debug build to work locally but not a release build. This issue is a pretty significant usability struggle for me. Do you have time and inclination to just release a patch or minor release with 66e0f51?
Sure, just tagged a new release for latest commit. https://github.com/chipsenkbeil/choose/releases/tag/1.2
See forumla update for release build: Homebrew/homebrew-core@master...chipsenkbeil:patch-2
It might also be good to support building head using homebrew brew install choose-gui --HEAD. I thought formula supported this out of the box if you specify the repo, but looks like you have to provide a head parameter: https://docs.brew.sh/Formula-Cookbook#unstable-versions-head
I agree on adding a head line to the formula. I tried to do that but don't want to PR into homebrew until it's actually succeeding for me and I'm still hitting the lack of release build missing file issue.
Looking at your homebrew PR, it's failing CI. I'm thinking choose -h is either returning nonzero or maybe something is hanging and timing out?
@focusaurus, with cdc986e, I changed the default build profile to debug. You can build the release version with xcodebuild -configuration Release build. Have you been getting issues with that configuration? Separately, not sure why the PR is failing at the moment.
I did a release build but the executable fails with illegal hardware instruction so I'll just wait for that homebrew PR to land.
@chipsenkbeil How do you think we should try to help the homebrew-core PR land? I'm not sure why choose -h seems to be timing out in CI for them. Locally it works and exits code 0 for me.
@focusaurus, I'm not sure at this time. My availability to dive into homebrew formulas is a bit limited at the moment, so if anyone else wants to investigate I'd be happy to have them take over the PR for homebrew (and any changes we need to make here).
@focusaurus version 1.2.1 has been merged into homebrew formula. Give it a try and see if it helps.
Perfecto! Thanks so much. Also shout out to my coworker @garretcarrot for that bug fix which unblocked this!