chiztechnology/Israel-Portfolio

Portfolio Application: Peer to peer code review

Closed this issue ยท 0 comments

Suggestions โ™ป๏ธ

  1. Based on the figma template, the navbar has a position: fixed; position. So when the user scroll down, the navbar stay fixed. Kindly take it into consideration. ๐Ÿ˜ƒ
  2. Kindly make the live demo link of your portfolio website clickable in your README.md file. ๐Ÿ˜ƒ
  3. Based on the figma template, the background color of your headline section has a rounded border on the bottom left. ๐Ÿ˜ƒ
  4. Kindly take the 3rd suggestion into consideration for your about-me section of your website which is on the top right corner. ๐Ÿ˜ƒ
  5. It would be better to fix the indentation in your index.html file. Making correct indentation will make your code more readable and looking nice. ๐Ÿ˜ƒ

Highlights โœ…

  • Descriptive commit messages ๐Ÿ’ฏ
  • Used correct github flow ๐Ÿ’ฏ
  • Deployed the application using Github Pages in a great way ๐Ÿ’ฏ
  • Well structured and well organized written code ๐Ÿ’ฏ