Portfolio Application: Peer to peer code review
Closed this issue ยท 0 comments
Khawanin commented
Suggestions โป๏ธ
- Based on the figma template, the
navbar
has aposition: fixed;
position. So when the user scroll down, the navbar stay fixed. Kindly take it into consideration. ๐ - Kindly make the live demo link of your portfolio website clickable in your
README.md
file. ๐ - Based on the figma template, the background color of your headline section has a rounded border on the bottom left. ๐
- Kindly take the 3rd suggestion into consideration for your about-me section of your website which is on the top right corner. ๐
- It would be better to fix the indentation in your index.html file. Making correct indentation will make your code more readable and looking nice. ๐
Highlights โ
- Descriptive commit messages ๐ฏ
- Used correct github flow ๐ฏ
- Deployed the application using Github Pages in a great way ๐ฏ
- Well structured and well organized written code ๐ฏ