Gist _Summary.md file reports incorrect Operating System version
sync-by-unito opened this issue · 0 comments
The Vagrant image used by Package Verifier has been updated from Windows Server 2012 R2 to Windows Server 2019.
This is not reflected in the _Summary.md file in the gist report at the end of the verification process.
See vim-tux.portable v9.0.0501 - Passed - Package Tests Results / _Summary.md for an example of a gist created after the image change.
It is including the line:
* Tested against win2012r2x64 (Windows Server 2012 R2 x64)
Whereas this should now be:
* Tested against win2019 (Windows Server 2019)
n.b. I'm assuming the x64 designation is now redundant given there is no x86 version of Windows Server.
If I'm reading the code correctly, this is currently hard coded.
The quick fix here is updating the hardcoded strings, though it would be good to make them dynamic based on which image is actively being used (allowing for testing against multiple images at some point?)
In addition to this, changes will need to be reflected in the various tests, as you can find the string in a number of them.
┆Issue is synchronized with this Gitlab issue by Unito