Clustering sometimes changes when changing region coordinates, but not zoom level

Question

Clustering sometimes changes when changing region coordinates, but not zoom level

Opened this issue 9 years ago · 8 comments

Sometimes when changing the map view's center region, the update annotation sequence triggers (namely, in CCHMapClusterController's mapView:regionDidChangeAnimated:). This is due to the longitude delta check. Since calculating the zoom level is already included in this project, wouldn't it be better to use that instead? I have a fork which does just that, and I set the epsilon/difference threshold to a value to something small enough, but not too small to trigger a 'zoom change' when changing the region center.

Answer 1 · 2016-01-17T18:47:32.000Z

Does this recipe help?

Answer 2 · 2016-01-18T06:25:21.000Z

I used it before, but changing the clusters on the same zoom level (even when using the same region span, updateAnnotations would still get triggered) is not desirable for my use case. So I'm not actually sure if this is a bug, since what happens is contrary to what's intended – in the comments, at least.

Answer 3 · 2016-01-24T18:44:51.000Z

Sorry for the late reply. Might be a good idea to use CCHMapClusterControllerZoomLevelForRegion with a small delta to decide if the map has been zoomed.

Would you mind creating a pull request and trying out if this works?

Answer 4 · 2016-02-02T08:08:36.000Z

@choefele, sorry for the late reply as well. I'll get a PR working within this week. :)

Answer 5 · 2016-06-03T11:28:28.000Z

@choefele is there an equivalent of the recipe that you mentioned above for when when trying to select an annotation with selectAnnotation:andZoomToRegionWithLatitudinalMeters:longitudinalMeters:?

Otherwise, selecting an annotation programatically would most of the times change clustering, even when zooming didn't change.

I tried tried to use CLLocationDistance MKMetersBetweenMapPoints ( MKMapPoint a, MKMapPoint b ) to compute the latitudinalMeters and longitudinalMeters from the visibleMapRect, but it still sees it as a zoom.

I did some experiments at bhapca@2988453 and bhapca@4e57c75 to provide a way of selecting without zooming. Is there a way to achieve the equivalent behaviour with the current API ?

Answer 6 · 2016-06-03T13:45:10.000Z

Also, if setCenterCoordinate:animated: is buggy, so that it needs that workaround, wouldn't this line be a problem ?

Answer 7 · 2016-06-06T15:57:43.000Z

The code to select an annotation assumes that some zooming will happen anyway. I haven't worked on this behaviour for a while, so I don't know any workarounds

Answer 8 · 2016-06-07T15:15:49.000Z

I think there are several issues with selectAnnotation:andZoomToRegionWithLatitudinalMeters:longitudinalMeters:

Given a set level of zoom there's no way to select between different annotations without changing the clustering.
If called repeatedly, when the map is still animating from a previous call, the map ends up in the middle of the ocean.
If called repeatedly, after the animation from the previous call has settled, you may get errors like "ERROR: Trying to select an annotation which has not been added", at random.

These all can be seen with a change to the sample app that I made at:
https://github.com/bhapca/CCHMapClusterController/tree/select-annotation-issues. It simply provides a way to swap the selection between 2 annotations at the East and West sides of Berlin.

I placed a potential fix for all these issues on https://github.com/bhapca/CCHMapClusterController/tree/select-annotation-issues-fix, and created the PR at #126, if you wish to bring them into master.