chop-dbhi/dicom-anon

Questions Around Exception Handling

cancan101 opened this issue · 3 comments

cancan101 commented

Looking here why does an IOError stop execution whereas an unhanded Exception is continued?

jeffmax commented

Excellent question- I don't remember. It likely had to do with a specific issue I ran into locally, but you are right to point it out. It might have been that in the situation where I got an IOError I wasn't even able to move the file to quarantine. It could definitely use a comment. I appreciate the second set of eyes on this thing.

blakedewey commented

I think this can be closed. I changed the Exception to a pydicom specific error.

jeffmax commented

Agreed- this make sense now that you have called out the second error out as InvalidDicomError. I expect I assumed an IOError meant there was something wrong with the drive or mount and indicated nothing further would work. Thanks again.