Redd Coin won't update

[sutheep]

Reddcoin won't update on touchbar. Shows an error.

Traceback (most recent call last):
File "", line 5, in
ValueError: Unknown format code 'f' for object of type 'unicode'

[chrislennon]

Confirmed, I get errors for redcoin when using either of the following options:

• Relative $ Range (-$000 / +$000)
• Change % based on opening (+10%)
• Relative % Range (-8% / +10%)
• Relative $ Range based on user percentage (-$000 / +$000)

The others appear to work. Will investigate and push a correction today.

[sutheep]

Thanks Chris for the prompt response. Regards, Sutheep Singhsachakul

…

On Jan 22, 2018 15:35, "Chris Lennon" ***@***.***> wrote: Confirmed, I get errors for redcoin when using either of the following options: - Relative $ Range (-$000 / +$000) - Change % based on opening (+10%) - Relative % Range (-8% / +10%) - Relative $ Range based on user percentage (-$000 / +$000) The others appear to work. Will investigate and push a correction today. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUMfZygyn5LJxLrdpCyWbOnax5FyWGXiks5tNEhTgaJpZM4RmK9p> .

[chrislennon]

@sutheep #70 should of now fixed this - and should now be deployed, I hadn't checked the 'advanced options' fully.

Give it a test see if you can replicate it - if you run into it again just let me know which coin and which settings (or a copy of the script) 😄

[sutheep]

Hi Chris, It’s still happening. It’s REDDCOIN (RDD). Also happening to a lot of alt coins. Script: import urllib2,json,sys data = urllib2.urlopen(" https://min-api.cryptocompare.com/data/pricemultifull?fsyms=RDD&tsyms=USD") obj=json.load(data) current = "{:0,}".format(obj["RAW"]["RDD"]["USD"]["PRICE"]) opening = obj["RAW"]["RDD"]["USD"]["OPEN24HOUR"] high = "{:0,}".format(obj["RAW"]["RDD"]["USD"]["HIGHDAY"]) low = "{:0,}".format(obj["RAW"]["RDD"]["USD"]["LOWDAY"]) raw_current = float(obj["RAW"]["RDD"]["USD"]["PRICE"]) raw_opening = float(obj["RAW"]["RDD"]["USD"]["OPEN24HOUR"]) raw_high = float(obj["RAW"]["RDD"]["USD"]["HIGHDAY"]) raw_low = float(obj["RAW"]["RDD"]["USD"]["LOWDAY"]) if (raw_current > raw_opening): trend = "▲" else: trend = "▼" print(“$" + current + " " + trend) Result: Traceback (most recent call last): File "<string>", line 5, in <module> ValueError: Cannot specify ',' with 's'. Sutheep Singhsachakul

…

On Mon, Jan 22, 2018 at 4:54 PM, Chris Lennon ***@***.***> wrote: @sutheep <https://github.com/sutheep> #70 <#70> should of now fixed this, I hadn't checked the 'advanced options' fully. Give it a test see if you can replicate it - if you run into it again just let me know which coin and which settings (or a copy of the script) 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUMfZ8-b2D4rFNH6WQ2gUU0KZK8I_8pbks5tNFrIgaJpZM4RmK9p> .

[chrislennon]

Hey, thanks for the code (by the way can use 3 ` symbols to start and stop a code block).

Thanks to your response i think i see the issue. Looks like the formatting options are causing issues for certain coins - I'm going to dig into this soon to see if i can resolve it globablly.

However for now, in your example above it looks like unticking 'Separate thousands with commas' and keeping the decimal places to infinite resolves it for now.

Will update this ticket when I have a a better fix in place.

[chrislennon]

This issue has been closed as part of #76.

After moving to python away from applescript there were a few issues regarding formatting options. This PR should resolve the issues going forward, please let me know if it works and of course if the issue continues reopen this issue and we can debug further.