Incompatible with Numpy 1.24

Question

Incompatible with Numpy 1.24

Opened this issue 2 years ago · 7 comments

Numpy 1.24 was released recently, and it looks like there is (at least one) deprecation that abydos relies on. Relevant stack trace snippet below.

Opening this for tracking purposes.

  File "/.venv/lib/python3.10/site-packages/abydos/distance/_aline.py", line 25, in <module>
    from numpy import float as np_float
ImportError: cannot import name 'float' from 'numpy' (/.venv/lib/python3.10/site-packages/numpy/__init__.py)

A fast solution to this would be to update the numpy version constraints in pyproject.toml/setup.py (this project has both and I don't know which is used for build) to also include <1.24.

Answer 1 · 2022-12-22T14:31:27.000Z

Given last commit in Jan 2021, I wouldn't get my hopes up.

Answer 2 · 2022-12-22T14:35:18.000Z

Apologies. I’m working on it but having some difficulty with GitHub at the moment. Hoping to have packages out with support for current Pythons & supportiing packages (e.g. NumPy) by year’s end.

…

On Thu, Dec 22, 2022 at 6:31 AM Michał Górny ***@***.***> wrote: Given last commit in Jan 2021, I wouldn't get my hopes up. — Reply to this email directly, view it on GitHub <#283 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALNF5V23OF4I2HHA5OBIUDWORQ4TANCNFSM6AAAAAATDTC4VE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Answer 3 · 2022-12-22T15:00:33.000Z

Thanks for letting me know. In that case, I'll give it a try and see if I can make a PR to fix it.

Answer 4 · 2022-12-22T15:07:32.000Z

Hmm, actually, it looks like master is good already, just needs a new release.

Answer 5 · 2023-03-08T12:29:24.000Z

Hi, are there any updates on this issue? I've installed abydos v0.5.0 (via PyPI) and v0.6.0 (via GIT) but i'm getting the above error with both versions.

Answer 6 · 2023-09-27T16:26:17.000Z

it's been a year, if the problem is fixed on master can a new release be cut?

Answer 7 · 2024-02-05T14:09:23.000Z

@joaodperes @bwo the issue seems to be fixed in 0.6.0b version which was merged to master. Use git to install the package or if you use poetry, use poetry add git+https://github.com/chrislit/abydos.git. It worked from my end :)