chrislusf/gleam

backward incompatible change in github.com/xitongsys/parquet-go

mschneider82 opened this issue · 1 comments

% go build                                                                                                                  
# github.com/chrislusf/gleam/plugins/file/parquet
../../go/pkg/mod/github.com/chrislusf/gleam@v0.0.0-20201128110619-d48afd638bae/plugins/file/parquet/parquet_file_reader.go:8:2: imported and not used: "github.com/xitongsys/parquet-go/types"
../../go/pkg/mod/github.com/chrislusf/gleam@v0.0.0-20201128110619-d48afd638bae/plugins/file/parquet/parquet_file_reader.go:73:29: undefined: ParquetTypeToGoType

it seems in v1.6.0 that functions was removed.
Doing go get -u github.com/xitongsys/parquet-go@v1.5.4 solves the problem for me, but it would be better if gleam had some go.mod file

@xitongsys breaking API Changes should be done in a v2 version, doing it in v1 will break every thing. please see https://blog.golang.org/v2-go-modules

@xitongsys could you please help (again) on updating the parquet APIs? It will be nice not to be fixed to an old version.