chroma-sdk/Colore

Fix code style issues

Sharparam opened this issue · 4 comments

Sharparam commented

There are some issues with the codebase that would be nice to fix:

  • Code style is inconsistent
    • E.g. some places use x == null or x != null instead of x is null and x is not null
    • Some places are missing braces around their bodies (like ifs and other control statements)

There are likely other similar issues given that the code has lived for quite some time by now.

fasetto commented

Can you assign this to me please?

mingweisoo commented

I am willing to work on this, please assign it to me.

Sharparam commented

Sure @fasetto :)

Sharparam commented

I'll close this for now, as the code issues outlined in here are fixed now. If I discover more discrepancies I'll create a new issue.