Turbosnap not trigger on dependency update
Closed this issue · 6 comments
We had a dependency update ("@chakra-ui/storybook-addon": "5.1.0") and that update cause an error in all storybook component, but no turbosnap made so the PR got an approve.
HI @Ankoge
I am currently struggling with similar issues (and already contacted the support)...
My observation is, that I have troubles with multiple package.json files in the same repo. I can configure base-urls/config-urls etc. whatever I want, but only changes to the package.json in the root directory of the repo trigger dependency-changes... Unfortunately all my code/storybook/chromatic is some levels deeper in the file tree.
I can update you if you have more info. @cgbl-90 if you have further ideas, I'd be glad (well, taking a look at your name I assume I am writing with you over the support :D)
@Ankoge i hope i don't hijack your thread, but just adding some details on the things i discovered (possibly they fit to your troubles)...
I enabled the --debug
flag and changed something in the package.json.. Then the log looks like:
Traversing dependencies for 2 files that changed since the last build
21:33:06.435 {"packageMetadataChanges":[{"changedFiles":["service/microfrontend/package.json"],"commit":"16013627f01a5ed76098fdab88f98778be28c34d"}]} Finding changed dependencies for 1 baselines
21:33:06.443 {"rootPath":"/home/my-git-root/git/my-repo","rootManifestPath":"package.json","rootLockfilePath":"yarn.lock"} Found manifest and lockfile
21:33:06.446 {"pathPairs":[["package.json","yarn.lock"]]} Found 1 manifest/lockfile pairs to check
21:33:06.446 {"filteredPathPairs":[]} Found 0 manifest/lockfile pairs to diff
(Context: the one package.json taken seems to be that in the repo root. While the one I really changed and the one I really use is service/microfrontend/package.json
, which is my project package.json)
As you can see, it decides that no dependencies were changed (which is, in fact, wrong) and then skips all snapshots.
Closing since this was moved to support