chromiumify/chromiumify.github.io

manifest.json incorrect and wrong Chrome path

dublx opened this issue · 4 comments

dublx commented

When following the website instructions, after the gen command I got a incorrect manifest.json, it was missing the very last curly brace.
Also, for the Mac Chrome link that worked for me was:
CHROME='/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome'

Based in commit 855fdf2.

No9 commented

Thanks for having a look @dublx !
This was super helpful.

As well as the manifest problem
https://github.com/chromiumify/chromiumify/blob/master/templates/manifest.json#L27

this also highlighted a missing test
https://github.com/chromiumify/chromiumify/blob/master/test/run.js#L6

Which in turn raised this missing option on gen
https://github.com/chromiumify/chromiumify/blob/master/index.js#L23

All three are now committed and published to npm. 2.1.1

If you get a chance to test and close that would be really appreciated.

No9 commented

@dublx Just realized you mention wrong chrome path in the issue header.

The path you gave is the same as I had in the runner for darwin.
Can you paste the error you are seeing when the app tries to run in here please so I can investigate further.

No9 commented

Ah think it needs a double escape for the \

No9 commented

Yup that was it finally got temp access to a mac to debug
See https://github.com/chromiumify/chromiumify/blob/master/index.js#L45