Bad results from Scanner.scan() for expressions like div, div div

[lukaseder]

When I run this code:

Scanner scanner = new Scanner("div, div div");
List<List<Selector>> selectors = scanner.scan();

I get a list with 3 elements:

System.out.println(selectors.size());
System.out.println(selectors.get(0).size());
System.out.println(selectors.get(1).size());
System.out.println(selectors.get(2).size());

prints:

3
1
2
2

It looks like the last "div div" is duplicated. This may lead to inefficient matching, when executing the selection.

[chrsan]

Yep, something wrong there. If you have a clue as of now please feel free to send me a pull request.

[lukaseder]

I haven't analysed it just yet. I'll do later on...
So far I only know that it doesn't produce "wrong" output. selectors.get(1) and .get(2) seem identical, so they match the same nodes...

[chrsan]

I'll have a look at it when I have time to do so. It's bad to have to do the checks twice and even worse if it's a heavy expression so to speak.

[chrsan]

Fixed the big and added a test case for it.

[lukaseder]

Awesome! Works like a charm!

[chrsan]

Great!