cibernox/ember-power-select

Dropdown opens at wrong place (location of <BasicDropdownWormhole />?) with version 8.0.1

bracke opened this issue · 6 comments

bracke commented

Hi

I have a dropdown which should open in a field in a table row. Instead it opens outside the table when I click. I think its where the BasicFropdownWormhole is.
This worked fine with version7.

 <PowerSelect
              @options={{@actions}}
              @selected={{appointment.action}}
              @onChange={{fn this.UpdateAction appointment}}
              @triggerClass="bootstrap-theme-trigger dataselect overflow-hidden"
              @dropdownClass="in-modal-dropdown slide-fade bootstrap-theme-dropdown w-25"
              @allowClear={{true}}
              @searchEnabled={{true}}
              @renderInPlace={{false}}
              @searchField="name"
              ...attributes as |action|
            >
              <div class="autocomplete_item w-100" data-test-autocomplete_item>
                <span class="autocomplete_item text-nowrap" data-test-item style="font-variant-numeric: tabular-nums">
                  {{action.name}}
                </span>
              </div>
 </PowerSelect>
mkszepp commented

@bracke on which place do you have <BasicDropdownWormhole />? Before or after {{outlet}}?

I think the best way should be before the {{outlet}} in application.hbs (because this is more/less the position which was in v7)

bracke commented

I have moved it before outlet but now its displayed before the table. It should be displayed where i clicked to open it.

Note:
The app uses ember-wormhole for some other stuff and bootstrap also uses some wormhole thing.
Could this maybe interfere?

bracke commented

I think I figured out what was missing:

The import statement in app.js was missing.
If I add it then the dropdown is displayed correctly although not "bootstrappy".

According to https://ember-power-select.com/cookbook/bootstrap-theme
I should replace the import statement with "import 'ember-power-select/themes/bootstrap';"
But If I do that the build fails?

mkszepp commented

@bracke thanks for debugging.. looks like we have broken this import in a beta version... not sure when it was occured... I have prepared a fix.

I have also extended the migration docs for theme

mkszepp commented

@bracke fix was released in v8.0.2. Let me know if this fix all your issues from this issue or if there is anything else what we need to patch

bracke commented

It fixes the problem :-)
Thank you for the very quick response.

  • ❤️1