Snapshot Volume also float64 instead of int64 !?

Question

Snapshot Volume also float64 instead of int64 !?

heiningair opened this issue 7 months ago · 5 comments

Is your feature request related to a problem? Please describe.
When using indicators, like e.g. trend.NewVwmafloat64 and executing a Compute on it, channels need to be passed in (per Type definition) they need to match float64 in this case for closings and volume.

Describe the solution you'd like
When giving the Volume in the Snapshot type a float64 value instead of the int64 it would make things easier to work with, wouldnt it?

Answer 1 · 2024-06-17T04:19:13.000Z

Let me see.. I should be able to change it.

Answer 2 · 2024-06-18T08:58:58.000Z

that would be awesome. I assume that various ohlc structures out there handling that differently, but for calculations within this library structure aka the indicators, it might be easier...

Answer 3 · 2024-07-19T09:18:41.000Z

Thanks cinar!

Changing the volume data type to float64 would be immensely useful for assets traded in fractions (e.g. cryptocurrencies).

Answer 4 · 2024-07-19T16:31:16.000Z

I'll take care of it today quickly. I feel it will be an easy one.

Answer 5 · 2024-07-20T20:04:04.000Z

I made the change. You can use it starting from Release v2.1.0. Please let me know if I missed anything.