cioccarellia/ksprefs

Updating to kotlin 1.3 to add experimental support for unsigned types

JonasSchubert opened this issue · 5 comments

Kotlin 1.3 is now supporting unsigned types. It is still experimental, but might be interesting. Do you want to have that in your library?
I added it in my experimental branch

I think it may be kind of weird from a developer to really use it, but giving the user the biggest possible range of choices is always the best thing to do. Good idea :)
Any other type we're missing?

Wow, your implementation and refactoring was quick! 😄
Kotlin provides lots of types. but beside the new unsigned types I don't think they should be added.

Do you think that this may cause any problem from java usages? Because those classes doesn't exists there but to get a object of type UInt you need to pass a default argument that is UInt

Actually I did not think about that. But to get a type which only exists in Kotlin, but not in Java, first needs the save of such a type. And if you cannot load such a type you also cannot save it. So I would not worry about that.
It also seems supporting some kind of @unsigned annotation is discussed (or already implemented, I don't know, sorry) to load from Java to Kotlin (Source -> scroll to the bottom to Unresolved questions)

Well, since they are still experimental is better to see what happens in the future.
In the making we provide support for them, because as mentioned earlier they won't cause issues