circlecell/jsonlint.com

Support for large numbers in JSON formatting

joseph-norman opened this issue · 9 comments

joseph-norman commented

Hey guys,

I noticed earlier that supporting large numbers doesn't work ok when I attempt to format JSON (looks to be falling under the JavaScript large numbers arithmetic overflow issue).

Would you accept a PR for this issue?

finom commented

@joseph-norman can you show JSON string which causes this issue? Formatting is powered by jsbeautifier and it just adds needed spaces to code (as I know) and doesn't make changes to it.

joseph-norman commented

No problem, here's an example I'm using which gets padded with zeroes every time I'm using it:

{
    "test field": 7784926383189565243
}
finom commented

@joseph-norman is it about http://jsonlint.com/ ?

If yes, it works fine for me. Can you make CTRL+F5 and try again?

joseph-norman commented

Ah apologies, I'm trying this out on pro.jsonlint.com - is this provided by you guys? It appears to be working ok on jsonlint.com.

finom commented

@joseph-norman yes, provided by us but it's not actively maintained.

joseph-norman commented

Ah right I see - following from that, would that be something you'd accept a PR for?

finom commented

@joseph-norman need to talk to the owner

finom commented

@joseph-norman

we're working on a newer version and therefore we're not accepting pull requests for that right now

joseph-norman commented

Sorry for necro bumping but cheers for the update @finom !