circuitpython/CircuitPython_Org_Bundle

Wrong pypi_name in the json file

Opened this issue · 0 comments

The pypi name of displayio_annotation in the json file is incorrect

  • setup.py says circuitpython-displayio-annotation
  • the json file says "pypi_name": "circuitpython-org-displayio-annotation"

I believe circuitpython-build-tools uses the repository name:

https://github.com/adafruit/circuitpython-build-tools/blob/bdcdafdb903fc4faaaec619603d2b59bab10ccea/circuitpython_build_tools/scripts/build_bundles.py#L107-L110
https://github.com/adafruit/circuitpython-build-tools/blob/bdcdafdb903fc4faaaec619603d2b59bab10ccea/circuitpython_build_tools/scripts/build_bundles.py#L60-L67

Outside of renaming the module on pypi, or the repository, which are probably valid options that are not gonna break much things yet, this could be handled by having the pypi name in an additional metadata file, same as this: adafruit/circup#96 (comment) once circup moves to using the json file. (Which would require an update to circuitpython-build-tools).