cisco/ChezScheme

c/build.zuo should call s/update-revision

burgerrg opened this issue · 5 comments

The revision file currently generated does not include the second line. Moreover, it fails to work properly if .git is removed. The s/update-revision script is designed to update itself when exported to an archive file. This update will work when .git is removed.

mflatt commented

It would be good to call s/update-revision in some way that works at a vanilla Windows command prompt. The current Zuo script assumes that a ".git" means that git can be expected in the path, so maybe a bash associated with git can be used?

Thanks, I had not considered the vanilla Windows case. Perhaps we need a s/update-revision.bat to be used on Windows?

Another option is to use the same trick in c/build.zuo that s/update-revision uses, which is to place it in .gitattributes with an export-subst. Let me try that.

The loop that looks for a .git folder doesn't handle submodules correctly, since in them .git is a regular file. To see this, create a new repository and add ChezScheme as a submodule.

Matthew, removing s/update-revision and putting the logic into c/build.zuo seems to work well on Unix-like systems and Windows. Please see what you think: #748