ciscoheat/buddy

Custom EvalTest for travis-hx

Closed this issue · 10 comments

fponticelli commented

I spent some time making utest work with travis-hx so let me know if I can help.

profelis commented

Will be great to add standardised output in all libraries (like utest and buddy).

for example: -D travisOutput add special lines in end of output which travis-hx understand and correct parse.

ciscoheat commented

I think that can be done with a custom Reporter, so you can compile the tests with -D reporter=buddy.reporting.TravisReporter and get the output for travis-hx. How's that?

waneck commented

I'd be very happy to add the changes to the default eval test, so it can work out-of-the-box with buddy, if possible.

profelis commented

@waneck current buddy reporter write this line https://github.com/ciscoheat/buddy/blob/master/src/buddy/reporting/ConsoleReporter.hx#L111

with all needed data. But standardised output looks better, imo

ciscoheat commented

Thanks! I'll add it right away, just renaming it to TravisHxReporter to be more precise. :)

ciscoheat commented

Added now in a59a7df (0.14.4)

Any ideas how to standardize it? I don't know what are the chances that someone gets success: true in the output of some failed tests, shouldn't be too high.

The indexOf tests in EvalTest.hx could be changed to == 0 to do the test at the beginning of the line for some safety.

profelis commented

I found new problem,js.Sys use browser api.
waneck/travis-hx#4 (comment) @waneck explanation

I pached Sys https://github.com/profelis/bindx2/blob/master/test/buddy/TravisReporter.hx#L146
but not tested yet

profelis commented

still problem https://travis-ci.org/profelis/bindx2/jobs/41134469#L342

I'll try to pull request fix in core