ciscoheat/dataclass

Segmentation fault with toDynamic

Chlorodatafile opened this issue · 0 comments

Actually, when you use the function toDynamic from DynamicObjectConverter, without any option defined, it crash during the runtime.

It's easy to correct, there is the local patch applied, during the definition of options :

var options:ConverterOptions = opts == null ? {
        delimiter: Converter.delimiter,
        boolValues: Converter.boolValues,
        dateFormat: Converter.dateFormat
    } : {
        delimiter: opts.delimiter != null ? opts.delimiter : Converter.delimiter,
        boolValues: opts.boolValues != null ? opts.boolValues : Converter.boolValues,
        dateFormat: opts.dateFormat != null ? opts.dateFormat : Converter.dateFormat
    };

It force the type ConverterOptions, to make it lighter, and also check the case where opts is null, because it's why you can get an Segmentation Fault.