Support for PostgreSQL 12

Question

Support for PostgreSQL 12

df7cb opened this issue 5 years ago · 17 comments

Trying to build cstore_fdw with 12beta1:

15:29:44 make[1]: Entering directory '/<<PKGBUILDDIR>>'
15:29:44 Makefile:45: *** PostgreSQL 9.3 or 9.4 or 9.5 or 9.6 or 10 or 11 is required to compile this extension.  Stop.
15:29:44 make[1]: Leaving directory '/<<PKGBUILDDIR>>'

IMHO it would be better to just ditch that check. If it doesn't compile, it doesn't compile, but if it compiles and passes the tests with the new version, I could just update the Debian package now, without having to poke upstream.

Answer 1 · 2019-08-22T22:00:33.000Z

I'll spoil the surprise for you & let you know there are compile errors when compiling against version 12

Answer 2 · 2019-08-23T16:34:09.000Z

Reopening to track PG12 support.

Answer 3 · 2019-08-23T17:35:43.000Z

I started a branch yesterday, https://github.com/citusdata/cstore_fdw/commits/pg12 but it's failing tests over files not existing & my guess is that I'm not correctly managing tuple slots

Answer 4 · 2019-09-27T14:43:05.000Z

ping. v12 is due next week.

Answer 5 · 2019-09-30T08:13:59.000Z

Although @serprex s work make code compile with PG12, There are some changes in PG12 on how relfilenode entry is treated in pg_class for foreign tables. I haven't yet to investigate in deep, however it requires some non-trivial work on our end.

It looks like we won't be able to ship compatible cstore_fdw version on time.

Answer 6 · 2019-10-01T11:39:38.000Z

Thanks for the update.

Answer 7 · 2019-10-28T22:06:24.000Z

Hello, any news regarding postgres12 support?

Answer 8 · 2019-10-29T09:08:36.000Z

Debian is also waiting.

Answer 9 · 2019-12-13T16:41:20.000Z

Ping @mtuncer, @serprex Any updates on this?

Answer 10 · 2019-12-13T18:16:19.000Z

@kakoni no, @DimCitus was going to look into it further, but he's been busy

Answer 11 · 2020-02-05T13:27:02.000Z

Hi,
Ubuntu also waits for this (just like Debian).
We wanted to have no postgresql-11 left in the upcoming LTS release 20.04 and right now cstore-fdw is one of the few holding it in.

Since the Feature Freeze date for 20.04 comes closer I wanted to ask again if @DimCitus or anyone else has made progress on this?

Answer 12 · 2020-02-08T15:56:42.000Z

Is Citusdata/Microsoft still supporting this extension or should I remove it from apt.postgresql.org and Debian?

Answer 13 · 2020-02-10T09:19:16.000Z

Hi @df7cb could you allow us a week on this. I have already started looking into it.

There is a compatibility issue with PG12 that required some work. I should have the fix sometime early next week.

Answer 14 · 2020-02-12T07:24:09.000Z

@mtuncer - thank you so much for your reply, glad to see a sign of life.

cstore-fdw is removed from Debian and Ubuntu for now. But I think @df7cb (for Debian) and myself (for Ubuntu) are more than happy to bring it back in as soon as it works. So let us know when the code is ready and if possible tag a new version with it right away so we can pick that.

The next related date should be the Ubuntu 20.04 Feature Freeze on 27th of February. Therefore if you'd really have it ready early next week it would be great to just slip back in before the freeze.

Answer 15 · 2020-02-18T12:22:01.000Z

@df7cb @cpaelzer @devrimgunduz @kakoni @pabloa PG12 support related changes are merged to master and released under tag v1.7.0

Answer 16 · 2020-02-18T14:09:42.000Z

Tthanks @mtuncer ! Pushed 1.7.0 to repos!

Answer 17 · 2020-02-19T09:48:42.000Z

Debian packages also updated, thanks!