shortcuts aren't checked, causing ui crashes
dVoooo opened this issue · 0 comments
Steps to reproduce:
- Press
"Ctrl + Z" (undo plan step),
"Ctrl + Enter" (implement plan) or
"Ctrl + Shift + Z" (redo plan step)
outside planning mode.
What happens:
Shortcuts causing ui crashes because they aren't properly checked. They should only react / execute if they are applyable.
Environment:
Citybound version: v0.1.2-702-g3bee9f5
Windows 10 1803
Opera 56.0.3051.52
Errors:
"Ctrl + Enter"
Error: unreachable
__rust_start_panic in wasm-function[4946] 1:undefined
rust_panic in wasm-function[4941] 30:undefined
std::panicking::rust_panic_with_hook::h718e0459ad45bd30 in wasm-function[4936] 444:undefined
std::panicking::continue_panic_fmt::h872ba9b1bbadd8aa in wasm-function[4935] 122:undefined
rust_begin_unwind in wasm-function[4934] 3:undefined
core::panicking::panic_fmt::h3ccc915db8b94b65 in wasm-function[5083] 70:undefined
core::result::unwrap_failed::h597351d3fc2feeef in wasm-function[84] 130:undefined
implement_proposal in wasm-function[111] 801:undefined
implement_proposal in ../target\wasm32-unknown-unknown\release\citybound_browser.js 764:28
implementProposal in ../src\planning_browser\Planning.js 167:18
Error: Cannot read property 'renderFrame' of null
onFrame in ../src\citybound.js 97:38
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:365
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:161
citybound_browser::MainLoop::frame::h9be28f0294273a01 in wasm-function[102] 1794:undefined
_$LT$stdweb..webcore..newtype..Newtype$LT$$LP$stdweb..webcore..serialization..FunctionTag$C$$u20$$LP$A12$C$$RP$$RP$$C$$u20$stdweb..webcore..once..Once$LT$F$GT$$GT$$u20$as$u20$stdweb..webcore..serialization..FuncallAdapter$LT$F$GT$$GT$::funcall_adapter::h999af828147914e5 in wasm-function[215] 683:undefined
dyncall in ../target\wasm32-unknown-unknown\release\citybound_browser.js 424:39
output in ../target\wasm32-unknown-unknown\release\citybound_browser.js 181:34
"Ctrl + Z"
Error: unreachable
__rust_start_panic in wasm-function[4946] 1:undefined
rust_panic in wasm-function[4941] 30:undefined
std::panicking::rust_panic_with_hook::h718e0459ad45bd30 in wasm-function[4936] 444:undefined
std::panicking::continue_panic_fmt::h872ba9b1bbadd8aa in wasm-function[4935] 122:undefined
rust_begin_unwind in wasm-function[4934] 3:undefined
core::panicking::panic_fmt::h3ccc915db8b94b65 in wasm-function[5083] 70:undefined
core::result::unwrap_failed::h597351d3fc2feeef in wasm-function[84] 130:undefined
undo in wasm-function[109] 801:undefined
undo in ../target\wasm32-unknown-unknown\release\citybound_browser.js 756:28
undo in ../src\planning_browser\Planning.js 482:59
Error: Cannot read property 'renderFrame' of null
onFrame in ../src\citybound.js 97:38
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:365
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:161
citybound_browser::MainLoop::frame::h9be28f0294273a01 in wasm-function[102] 1794:undefined
_$LT$stdweb..webcore..newtype..Newtype$LT$$LP$stdweb..webcore..serialization..FunctionTag$C$$u20$$LP$A12$C$$RP$$RP$$C$$u20$stdweb..webcore..once..Once$LT$F$GT$$GT$$u20$as$u20$stdweb..webcore..serialization..FuncallAdapter$LT$F$GT$$GT$::funcall_adapter::h999af828147914e5 in wasm-function[215] 683:undefined
dyncall in ../target\wasm32-unknown-unknown\release\citybound_browser.js 424:39
output in ../target\wasm32-unknown-unknown\release\citybound_browser.js 181:34
"Ctrl + Shift + Z"
Error: unreachable
__rust_start_panic in wasm-function[4946] 1:undefined
rust_panic in wasm-function[4941] 30:undefined
std::panicking::rust_panic_with_hook::h718e0459ad45bd30 in wasm-function[4936] 444:undefined
std::panicking::continue_panic_fmt::h872ba9b1bbadd8aa in wasm-function[4935] 122:undefined
rust_begin_unwind in wasm-function[4934] 3:undefined
core::panicking::panic_fmt::h3ccc915db8b94b65 in wasm-function[5083] 70:undefined
core::result::unwrap_failed::h597351d3fc2feeef in wasm-function[84] 130:undefined
redo in wasm-function[110] 801:undefined
redo in ../target\wasm32-unknown-unknown\release\citybound_browser.js 760:28
redo in ../src\planning_browser\Planning.js 483:59
Error: Cannot read property 'renderFrame' of null
onFrame in ../src\citybound.js 97:38
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:365
Module.STDWEB_PRIVATE.to_js in ../target\wasm32-unknown-unknown\release\citybound_browser.js 670:161
citybound_browser::MainLoop::frame::h9be28f0294273a01 in wasm-function[102] 1794:undefined
_$LT$stdweb..webcore..newtype..Newtype$LT$$LP$stdweb..webcore..serialization..FunctionTag$C$$u20$$LP$A12$C$$RP$$RP$$C$$u20$stdweb..webcore..once..Once$LT$F$GT$$GT$$u20$as$u20$stdweb..webcore..serialization..FuncallAdapter$LT$F$GT$$GT$::funcall_adapter::h999af828147914e5 in wasm-function[215] 683:undefined
dyncall in ../target\wasm32-unknown-unknown\release\citybound_browser.js 424:39
output in ../target\wasm32-unknown-unknown\release\citybound_browser.js 181:34