⚡[FEAT] Loading spinner could accept text
Closed this issue · 6 comments
Is your feature request related to a problem? Please describe.
Not a problem, more of an efficiency thing. We moved from the text Loading... to spinners, but sometimes having text withthe spinner is nice to help clarify what is loading.
Describe the solution you'd like
The LoadingSpinner component could accept an optional text value, and display it with the spinner.
I would like to take this up!
Awesome, thanks @abdullahranginwala!
Feel free to submit a PR linked to this issue and if you have any questions, let me know!
@whoabuddy Thank you, I am super excited for this opportunity. I have made the necessary changes but it is unclear what you mean by 'optional text'
Happy you are enjoying it! Where did you make the changes? Are you going to submit a pull request?
As far as the "optional text", I mean if I pass in text as a prop to the component, it should render it, otherwise it should just load the spinner if not.
Here is an example of a FormResponse component that accepts a txId, but doesn't show anything if it's blank:
Then when it's called, you either pass the info or a blank value:
(this comes from a WIP branch, but outlines the general idea)
Understood! I have made changes to the LoadingSpinner.js file. As soon as I configure the props I will submit a pull request