Seems to break React Server Components

Question

Seems to break React Server Components

Kyoss79 opened this issue 2 years ago · 4 comments

Hello,

been using this library up to now.
It seems the library is using React Context internally,
which breaks the new NextJS App Directory using Server Components.

Answer 1 · 2023-01-30T13:44:37.000Z

Hi @Kyoss79! Can you point me where we are using React Context? It's been a while since I was in this codebase so I might be missing something but I can't find it.

I wouldn't be surprised if react-waypoint is incompatible with newer React tech (like NextJS app dir), so one possible solution would be for you to move to IntersectionObserver (either via a library or directly against the browser API).

Answer 2 · 2023-01-30T20:08:12.000Z

By looking through the code, the problem seems to be within "react-is".

c=Symbol.for("react.context"),u=Symbol.for("react.server_context")

Mhmm

Answer 3 · 2023-01-30T20:37:36.000Z

I believe that code is part of the react repo: https://github.com/facebook/react/blob/1f5ce59dd7b6869b1a17ede65aa301002ef31d4b/packages/shared/ReactSymbols.js#L21-L24

Answer 4 · 2023-01-31T09:12:18.000Z

i couldn't look any deeper into this and changed react-waypoint for react-intersection-observer.

Kinda sad, I liked your API more.