civo/terraform-provider-civo

[BUG] No validation of field size for civo_instance resources

Closed this issue · 0 comments

Description

Issues

Using a completely wrong size field causes terraform to keep trying to provision this resource for two minutes rather than failing straight away:

resource "civo_instance" "foo" {
    hostname = "amazingthingy20"
    tags = ["python", "nginx"]
    notes = "This is a test-issue"
    size = "sdfsdfsdf" # this value is wrong
    region = "LON1"
    firewall_id = "default-default"
    disk_image = "debian-11"
}
image

This should fail straight away as it does on the API, CLI, etc. Not keep retrying

Acceptance Criteria

  • Have this resource fail straight away when entering the wrong value and return the error from the API

This ticket should be used as a reference for a bigger piece of work revamping the way we handle errors in terraform. The default behaviour with our provider seems to be to keep trying and it does NOT return the error the API gives, which is a problem.

We need to go through the entire provider and change the behaviour for everything not by writing error messages in terraform provider, but returning errors from the API

Screenshots

No response

Additional information

No response