cjbassi/ytop

With light background unreadable

Closed this issue · 8 comments

rofrol commented

image

Required information:

  • ytop version (ytop -V): ytop 0.5.1
  • The output of uname -a: Linux roman-MS-7B43 5.3.0-40-generic #32-Ubuntu SMP Fri Jan 31 20:24:34 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Include any of the following information if relevant:

  • Terminal emulator (e.g. iTerm or gnome terminal): gnome terminal
  • tmux version (tmux -V):
  • Any relevenat hardware info:

Please copy or attach ~/.local/state/ytop/errors.log if it exists and contains logs:

cjbassi commented

Could you see if one of the other color schemes would work better? Specifically the default dark color scheme?

rofrol commented

default-dark looks best, though still too light sometimes:

default-dark

monkai:

monokai

solarized-dark:

solarized-dark

vice:

vice

cjbassi commented

default dark is supposed to be good for light backgrounds so if you wanna improve it and open a pr then that would be fine with me 👍

rofrol commented

But why your light https://github.com/cjbassi/ytop/blob/master/assets/screenshots/minimal.png looks good and mine not? I am using colors from system theme in Ubuntu.

cjbassi commented

Hmm, I'm not sure. The colors do seem different, and you're also missing bold characters. Maybe a terminal issue?

rofrol commented

For bold I am using font which does not have bold.

cjbassi commented

And I think the colors just come down to your terminal colors.

cjbassi commented

I'm going to close this issue since i think this just comes down custom terminal settings.