End of Life notice
Opened this issue · 6 comments
@cjmanca Following this notice:
Since I heard that Plex had been working on their own version of credit detection which will soon make it's way into the official PMS, I stopped working on this, and will no longer provide updates.
I'd just like to throw my 2 cents here and note that AFAIK Plex already has a similar thing to this (but only for opening credits), but that's only available to Plex Pass subscribers. plex-credits-detect offloads the work into your PMS. I doubt that even if they are working on improving it, it'll be available for non-Plex Pass subscribers, so I'd appreciate keeping this project alive.
Plex's new feature is for end of show credits (and yes, for pass subscribers - which I highly recommend picking up at their occasional ~$90 for life pricing)
for @cjmanca -- THANK YOU!! This has been a great stopgap prior to getting the native feature. Now that we're done here, Is any database cleanup required that you're aware of? Thanks again for your efforts here.
plex-credits-detect continues to fill other holes for me, even now that Plex is detecting end credits on its own. Plex still doesn't offer any way to detect multiple intros or customize how far into a show it looks for intros, and I've got shows in my library that benefit from both of those (with intros well into the show, or which have long studio intros at the start of the file, and then the actual intro later into the file).
Plex's update solves one problem, but there are still others that I really appreciate this project solving for me.
it'll be available for non-Plex Pass subscribers, so I'd appreciate keeping this project alive.
Even with the current project, you still need to be a Plex Pass subscriber to make use of them. All this does is add the markers to the database, you need a Plex subscription to make use of them when watching, so I don't see how this changes anything.
Plex still doesn't offer any way to detect multiple intros or customize how far into a show it looks for intros
That's a fair point, and I'll give it some thought as to whether to continue for that reason alone.
for @cjmanca -- THANK YOU!! This has been a great stopgap prior to getting the native feature. Now that we're done here, Is any database cleanup required that you're aware of? Thanks again for your efforts here.
No cleanup needed. When plex modifies markers in any way (adding it's own intros/credits), it completely strips all existing markers for that season before adding the new markers, so it should handle the cleanup on it's own as it generates credits.
it'll be available for non-Plex Pass subscribers, so I'd appreciate keeping this project alive.
Even with the current project, you still need to be a Plex Pass subscriber to make use of them. All this does is add the markers to the database, you need a Plex subscription to make use of them when watching, so I don't see how this changes anything.
There's another tool called Plex Auto Skip (https://github.com/mdhiggins/PlexAutoSkip) that works with your tool without the need for Plex Pass, don't think people really know they can do that, discovered it by mistake, still intend to get the lifetime pass next sale.
But also your tool allows users with Plex Pass to skip intros on a server where the owner doesn't have a Plex Pass, which is nice.
@cjmanca I can see another use for this - and curious if I could leverage what is available currently as is, or would need more work to be used how I see it to be used. As compliment to the current built in credit detection.
Problem is many of us run plex on lower powered nases, and credit detection seems to take forever.. I am on a ds918+ and currently its been running for 2 months.. Doing some math via looking in the database for what has credit markers and what doesn't seems I am looking at another 3 months of nas churning away during my 6 hour maint window at night, with pegging the nas cpu..
I would think it might be possible to run your tool on my much more powerful PC, point it at my nas with the info it needs to query the plex db for what has credit markers and what doesn't and since it can have access to the actual media files - do the credit detection on my PC, and then just update the makers.. Plex can still do its thing after hours, but I would think running your tool for a few hours a day different than when plex does its thing could drastically reduce the time needed to complete credit detection on my full library.. 3700 some movies and 21k something tv episodes... Plex running every night for 6 hours on my nas in 2 months seems to have only just gotten through about 40% of the media..