ckeditor/ckeditor4

Missing emoji assets in 4.11.0 release

Closed this issue · 2 comments

mlewand commented

Type of report

Bug

Provide detailed reproduction steps (if any)

With the release of 4.11.0 we added assets directory to ignored files list in CKBuilder.

That was meant to skip this particular directory, however it did also skip plugins/emoji/assets dir, so emoji has no icons.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.11.0
mlewand commented

To fix this problem we'll remove entries in CKBuilder to remove the assets dir: https://github.com/ckeditor/ckeditor-presets/blob/4574d6ad852b58d839c8822f16c5fbf331e9c1a4/presets/standard-build-config.js#L9

To keep builds clean we'll remove the /assets directory in repository root and simply put the npm image directly in our CDN.

mlewand commented

The image was uploaded to our CDN and can be found at: https://c.cksource.com/a/1/img/npm/ckeditor4.png