[stable 1.0.12] Cannot set property 'shaka' of undefined

Question

[stable 1.0.12] Cannot set property 'shaka' of undefined

me-vlad opened this issue 8 years ago · 25 comments

me-vlad commented 8 years ago

Browser: All with MSE (tested on Chrome, Chromium)

Clappr Version: 0.2.57
dash-shaka-playback version: 1.0.12

Steps to reproduce:

open http://cdn.clappr.io/ and change source to http://demo.unified-streaming.com/video/ateam/ateam.ism/ateam.mpd
enable dash-shaka-playback Plugin (1.0.12) https://cdn.jsdelivr.net/clappr.dash-shaka-playback/1.0.12/dash-shaka-playback.js
click on Run button, you'll see an error message: Cannot set property 'shaka' of undefined
click on Play button - default mp4 source (http://clappr.io/highline.mp4) playing instead of mpeg-dash stream

config tested with cdn.clappr.io:

var playerElement = document.getElementById("player-wrapper");
Clappr.Log.setLevel(0);
var player = new Clappr.Player({
  source: 'http://demo.unified-streaming.com/video/ateam/ateam.ism/ateam.mpd',
  baseUrl: '/latest',
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640,
  plugins: [DashShakaPlayback]
});
player.attachTo(playerElement);

Answer 1 · 2016-06-27T21:36:48.000Z

Thanks @me-vlad ! is this reproducible on BETA version? can you use the "BETA"?

Answer 2 · 2016-06-27T22:23:27.000Z

@leandromoreira my DASH stream has some issues with shaka2, so currently I use shaka1 (dash-shaka-playback stable with older clappr 0.2.51)

Answer 3 · 2016-06-27T22:36:55.000Z

@me-vlad okay, I'll branch out then and try to fix! :) if you want, you can open issues to theses issues too.

Answer 4 · 2016-06-27T23:37:24.000Z

@leandromoreira thanks!
I think shaka2 issue not caused by clappr plugin, I can reproduce it on shaka demo page http://shaka-player-demo.appspot.com/demo/

Answer 5 · 2016-06-27T23:53:32.000Z

You can then open an issue at https://github.com/google/shaka-player to help them build a better player!

Answer 6 · 2016-06-28T00:06:44.000Z

@leandromoreira sure, I'll clarify details and will open an issue at shaka-player repo

Answer 7 · 2016-06-28T00:10:02.000Z

you can refer this issue there too if you want.

Answer 8 · 2016-06-28T13:49:06.000Z

@me-vlad https://github.com/clappr/dash-shaka-playback/releases/tag/1.0.13 can you test it?

Answer 9 · 2016-06-28T16:05:59.000Z

@leandromoreira just tested on cdn.clappr.io with v. 1.0.13 from https://cdn.jsdelivr.net/clappr.dash-shaka-playback/1.0.13/dash-shaka-playback.js

I see an error after clicking on Run button:
Cannot read property 'isLive' of undefined

Answer 10 · 2016-06-28T17:13:40.000Z

it should be fixed now @me-vlad thanks again

Answer 11 · 2016-06-28T17:47:37.000Z

@leandromoreira sorry but with version 1.0.14 from https://cdn.jsdelivr.net/clappr.dash-shaka-playback/1.0.14/dash-shaka-playback.js - same error on cdn.clappr.io

Answer 12 · 2016-06-28T18:22:56.000Z

I see, the weird thing is if you just use the playback (npm start) everything run just fine.

Answer 13 · 2016-06-28T20:35:11.000Z

hopefully https://github.com/clappr/dash-shaka-playback/releases/tag/1.0.16 will solve

Answer 14 · 2016-06-28T20:44:12.000Z

@leandromoreira cool, it works!
just one minor issue - stream starts just after second click on the player (when autoPlay is set to false)

Answer 15 · 2016-06-28T20:51:16.000Z

I'm trying to fix that now @me-vlad :D 17 is up!

Answer 16 · 2016-06-28T21:06:35.000Z

17 does not solve that too!

Answer 17 · 2016-06-28T21:19:49.000Z

I bet solved it.

Answer 18 · 2016-06-28T21:32:16.000Z

:) yes, but...
after clicking on stop button player starts buffering

Answer 19 · 2016-06-28T21:33:30.000Z

is it live? do you have this source?

Answer 20 · 2016-06-28T21:36:44.000Z

yes, you can try with this stream
http://live.unified-streaming.com/loop/loop.isml/loop.mpd

var playerElement = document.getElementById("player-wrapper");
Clappr.Log.setLevel(0);
var player = new Clappr.Player({
  source: 'http://live.unified-streaming.com/loop/loop.isml/loop.mpd',
  baseUrl: '/latest',
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640,
  plugins: [DashShakaPlayback]
});
player.attachTo(playerElement);

Answer 21 · 2016-06-29T03:36:15.000Z

@me-vlad I think it's finally solved thank you so much for all the tests, can you redo all of them?

Answer 22 · 2016-06-29T13:12:10.000Z

@leandromoreira thanks, I tested live and vod stream again with https://cdn.jsdelivr.net/clappr.dash-shaka-playback/1.0.19/dash-shaka-playback.js, VOD works fine.
Live stream starts, after clicking on stop button stream stops and mediacontrol bar disappears but big play button not appears.
Streams starts again after click on the player.

Live test config:

var playerElement = document.getElementById("player-wrapper");
Clappr.Log.setLevel(0);
var player = new Clappr.Player({
  source: 'http://live.unified-streaming.com/loop/loop.isml/loop.mpd',
  baseUrl: '/latest',
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640,
  plugins: [DashShakaPlayback],
  hideMediaControl: false
});
player.attachTo(playerElement);

Answer 23 · 2016-07-05T13:38:44.000Z

@me-vlad I'm going to close this one and I ask you to open a new one :) (I noticed someone had catch this same bug while on hls ... maybe this is a clappr related, anyway)

Answer 24 · 2016-07-05T16:59:48.000Z

@me-vlad lol clappr/clappr#1062 I fixed

Answer 25 · 2016-07-05T17:00:06.000Z

let's wait a new clappr then we can update both versions! Thanks again.