clarkeash/doorman

Laravel 5.7 Compatibility

Closed this issue · 9 comments

wyoumans commented
Laravel 5.7 Compatibility
clarkeash commented

Updated laravel and test bench

clarkeash commented

First problem (mockery no longer installed by default)

screenshot 2018-10-06 at 20 16 53

clarkeash commented

2nd issue (looks like some timing precision has changed):

screenshot 2018-10-06 at 20 31 40

clarkeash commented

Okay, this is now working:

I am not overly found of the solution: $date = Carbon::now( 'UTC')->endOfDay()->startOfSecond(); add this startOfSecond() call feels a bit weird.

But tests are green:

screenshot 2018-10-06 at 20 57 21

clarkeash commented

New issue: startOfSecond() doesnt exist in whatever version of Carbon ships with laravel 5.6

screenshot 2018-10-06 at 21 02 49

clarkeash commented

Solved:

screenshot 2018-10-06 at 21 12 08

will tag v2.1.0

wyoumans commented

Thanks a lot for your time. Really appreciate it.

  • 👍1
clarkeash commented

No problem 😄