classicrocker883/MRiscoCProUI

[BUG] Cancelling build mesh requires restart before being able to rebuild another mesh

Closed this issue · 19 comments

vw72 commented

Did you test the latest release build?

Yes, and the problem still exists.

Bug Description

Install December firmware - preheat printer and auto-build mesh. Press cancel during the mesh building. Subsequent attempts to auto-build mesh start but stop immediately with mesh cancelled message. Reboot printer and mesh building works as expected until cancelled, then you need to restart again to build a mesh.

Printer Model

Voxelab Aquila

Model Type

OG

Your Mainboard

Aquila GD32

Other Mainboard Type

No response

Add-ons that could be involved

BL Touch

ProUI?

ProUI

Bed Leveling

UBL - Unified Bed Leveling

Did you include your own configuration files?

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

I'm using a Creality display with the TJC chipset on the Voxelab, but I don't think it is related to this issue.

classicrocker883 commented

I'll take a look into this.

classicrocker883 commented

do you know if this had been fixed with the most recent release? if not I can make a test file with a change which might help

vw72 commented
vw72 commented
vw72 commented
classicrocker883 commented

if im not mistaken, some TJC displays may not work with gcode preview. I'm actually not sure theres not much info I can find about it Reddit post about this

I think for TJC you may need to use 180x180 , try that in the slicer.

classicrocker883 commented

are you able to compile your own?
in src/lcd/e3v2/proui/dwin.cpp

look for and add this to the function:

  void DWIN_LevelingDone() {
    DEBUG_ECHOLNPGM("DWIN_LevelingDone");
    #if HAS_MESH
      #if ALL(PROUI_EX, HAS_BED_PROBE)
        ProEx.LevelingDone();
      #else
        Goto_MeshViewer(true);
      #endif
    #endif
+   HMI_ReturnScreen();
  }
vw72 commented
vw72 commented
vw72 commented
classicrocker883 commented

Hi I am very close to this fix. So far I have been able to cancel normally, and re-level without restarting.
One thing I'm hung up on is when you press the button to cancel. it seems as though the button must be pressed at the right moment (like when its "not busy").

its a bit tricky to figure out since the code in question resides within the proui library - which are compiled files you cant just open and change, actually you cant even read them because its protected in a way.

so soon, I'm so close. also I mentioned in another comment asking about the TJC display, if there is an issue setting the value that isnt between 0-100. or 101-200. setting brightness should be linear. and I should have a fix next release.

and if you had any other recommendations what I can do that would help.

classicrocker883 commented

The preview works with TJC on the 20231027 version of the firmware

oh no... I think this is when we had fixed the issue regarding the preview - anytime you would click it more than a few times it would freeze and restart. what I can do is when TJC is enabled, I'll have it use that code set which worked for that.

oh also, did I mention this somewhere else? try changing the preview thumbnails to 180x180. in the "slicer scripts", in CreateJPEGThumbnail.py, look for "default_value": 200, and make it 180 for height and width [this is for Cura]
for PrusaSlicer you should be able to change it in the slicer settnigs.

if that doesnt work...I may have to change that in firmware. otherwise, I believe I need to have it use that the preview gcode preview thumbnail code from October

vw72 commented
vw72 commented
classicrocker883 commented

I have something you can test, its TJC-GD32_UBL-ProUI.bin
it also has some code I'm testing canceling the build mesh.

let me know if the gcode preview works.
Aquila-TJC-GD32_UBL-ProUI.zip

vw72 commented
classicrocker883 commented

oh that's right I forgot about it being TJC, Aquila displays have it reverse and I forgot to comment that line out.

well that sucks about the gcode preview... I had it reverted back since before the change, like u said was back in October. maybe I missed something.

When u mention when it worked, were u using 200x200 thumb size in slicer? have you tried Both Cura and Prusaslicer?

did I mention the slicer scripts have been updated? perhaps if you updated your slicer, maybe the scripts were lost/deleted. or maybe the new scripts aren't working properly for the TJC.

anyway I should have another release build any day.
I think I improved the mesh canceling a tad since.

classicrocker883 commented

https://github.com/classicrocker883/MRiscoCProUI/releases/tag/2.1.3f-2

here is the new release. ill make a list of changes later, let me know if anything needs adjusting

github-actions commented

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.