`SuccessMessageMixin` is missing
vdboor opened this issue · 5 comments
Hi,
As a request, I was hoping that django.contrib.messages.views.SuccessMessageMixin could be included as well. I think it's a valuable addition to mention, since it's designed to be used in combination with form views.
Super on board with this but the navbar is already straining under the weight of Generic + Auth, so adding Messages will definitely break the current navbar design. So yes we should do it, but it'll probably necessitate that little redesign rather than just being the one line of code it should be.
Maybe keeping everything from Generic in the top level but then grouping all contrib modules together under a Contrib (or "Other" or "More") dropdown is the way to go.
Fully agreed :-) making a "contrib" dropdown menu would definitely help here.
Shouldn't this just go under the mixin menu?
That mixin dropdown (and the views one next to it) is for auth, not generally.
As it is, the menus are organised by source (most of them are from Generic, those two are from Auth). Note that, for example, the form mixins are under Edit as that's where they're from: they're not under Mixins as that's just the auth.mixins module.
So no, without a redesign of the menus, it's not just a case of putting this under that