#f4e7ae4 | Compat
featherbear opened this issue · 2 comments
Hi!
Using the library today, I had to make changes to
LXDMXWiFi_Library/src/LXWiFiSACN.cpp
Line 234 in f4e7ae4
into
if ( interfaceAddr ) {
due to compiler errors
Secondly, after investigating why my ArtNet packets weren't being received
I changed
LXDMXWiFi_Library/src/LXWiFiArtNet.cpp
Line 268 in f4e7ae4
to
if ( _dmx_sender_a == INADDR_NONE ) {
(and likewise for
_dmx_sender_b
)
It seems that INADDR_NONE
is equal to -1, not 0.
but, I've previously used this library in late 2017/early 2018 and it worked.
Just wondering if you were aware of this, or it's some misconfiguration on my end
PR: #19
Commit f4e7ae4
NodeMCU V1 ESP8266
Arduino 1.8.9
I believe this is clarified in the latest commit. Also, this fixes the == comparison of IPAddress and 0 that throws a compile exception with the ESP8266 v2.5 board package.
Yep, d88b3ab fixes these issues
Thank you!