server closed when scan the qrcode

Question

server closed when scan the qrcode

Closed this issue 3 years ago · 14 comments

I'm opening this issue because:

I have found a bug
I want to request a feature
I have a question
Other

Server closed when scan the qrcode by my Android 8.0 phone(before the downloading), I didn't install Go on my macOS 10.14.6, But receiving files from mobile works fine.

Answer 1 · 2020-05-11T06:26:51.000Z

Hello @Symous, thanks for reporting. Let me ask you a few questions:

Which browser did you use on Android?
What was, approximately, the size of the file(s) you wanted to send?
After scanning the code, did Android ask you to choose which browser you wanted to use?

Thanks,
C

Answer 2 · 2020-05-11T06:37:59.000Z

hi @claudiodangelis, I also fount this BUG ,when i scan the qrcode,the browser will ask me is sure to download this file,but the qrcp is exit at the same time. when i add the -k tag is ok to download the file.

Answer 3 · 2020-05-11T06:41:17.000Z

@claudiodangelis Thanks for your help.

I use a browser made in China based on WebKit 537.36 Chrome 62.0.3202.97
I try to send a 16KB png file
I use the browser to scan the QR-Code directly, so there is no selection dialog after scanning.

Answer 4 · 2020-05-11T07:02:07.000Z

hi @claudiodangelis, I also fount this BUG ,when i scan the qrcode,the browser will ask me is sure to download this file,but the qrcp is exit at the same time. when i add the -k tag is ok to download the file.

@heyv5 I have seen this issue before but I could not reproduce it. Which type of file were you attempting to transfer?

@claudiodangelis Thanks for your help.

1. I use a browser made in China based on WebKit 537.36 Chrome 62.0.3202.97

2. I try to send a 16KB png file

3. I use the browser to scan the QR-Code directly, so there is no selection dialog after scanning.

@Symous thanks, could you please try passing the -k flag? (it means "keep alive") and tell me if it works?

I will investigate meanwhile.
Thanks for your patience,
C

Answer 5 · 2020-05-11T07:09:08.000Z

hi @claudiodangelis, I also fount this BUG ,when i scan the qrcode,the browser will ask me is sure to download this file,but the qrcp is exit at the same time. when i add the -k tag is ok to download the file.

@heyv5 I have seen this issue before but I could not reproduce it. Which type of file were you attempting to transfer?
@claudiodangelis Thanks for your help.
1. I use a browser made in China based on WebKit 537.36 Chrome 62.0.3202.97

2. I try to send a 16KB png file

3. I use the browser to scan the QR-Code directly, so there is no selection dialog after scanning.
@Symous thanks, could you please try passing the -k flag? (it means "keep alive") and tell me if it works?

I will investigate meanwhile.
Thanks for your patience,
C

is PNG file too

Answer 6 · 2020-05-11T07:13:15.000Z

@claudiodangelis yes, it works fine after add -k flag.

Answer 7 · 2020-05-18T03:51:20.000Z

One thought I'm just throwing out there is if https://github.com/claudiodangelis/qrcp/blob/master/server/server.go#L171 is not synchronous ( for a multipart response i believe it's not https://golang.org/src/net/http/fs.go?s=19375:19432#L268 ) the send handler goroutine would exit decrementing the waitgroup in turn triggering shutdown of the server. So maybe if a file is being sent as a multipart response the transfer starts but since execution continues on the main goroutine the server shuts down.

One possible way to debug this is view the network log on the receiving browser to see if the connection is closed prematurely . Another option is to craft a request including a range header https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range and send using an http client like curl.

Answer 8 · 2020-05-18T05:21:08.000Z

Hrm i tried this and i was able to receive all parts before the server closed. I didn't consider that graceful shutdown would handle this case. I believe my hypothesis is disproved.

Answer 9 · 2020-08-03T17:51:48.000Z

it's android's shit->Android browser issue. Download makes two requests instead one

Answer 10 · 2020-09-03T11:01:19.000Z

it's android's shit->Android browser issue. Download makes two requests instead one

Technically this should be already covered in the code, though from time to time I get a similar issue.
Will review the code soon and push a fix for the next release.

Thanks,
C

Answer 11 · 2020-09-07T18:10:00.000Z

I'm getting this with Firefox Android 80, I assumed it was because Firefox asks to confirm the download and that the app fails to take that into account, or maybe it's something else.

Answer 12 · 2022-03-14T17:05:58.000Z

Hello, are you still experiencing this issue? If so, please feel free to reopen the issue. Thanks!

Answer 13 · 2023-03-09T22:25:15.000Z

I am still suffering from this bug.

Answer 14 · 2024-09-22T02:19:15.000Z

Yeah me too. Latest version of MacOS and iOS Safari