clawpack/pyclaw

Single Time Stepping Raises Exception in Python 3.x

Closed this issue · 6 comments

mandli commented

When using single (or N) time steps with output_style = 3 tend = None gets passed into the solver which, in Python 3, cannot be compared to tstart which is a float.

mandli commented

To demonstrate change examples/acoustics_1d_homogeneous lines 84-88 to be

    claw.output_style = 3
    claw.nstepout = 1
    if disable_output:
        claw.output_format = None
    # claw.tfinal = 1.0
    claw.setplot = setplot
mandli commented

Suggested fix in #583

mandli commented

Does this need a test?

ketch commented

It looks like we ought to have a test that sets output_style = 3, so that a bug like this would be caught in the future. Could you add that?

I restarted the failed build in Travis and now it passes.

mandli commented

Yeah, I can add something.

ketch commented

Fixed by #583.