Conversion from a null element to <element/> is broken

Question

Conversion from a null element to <element/> is broken

Closed this issue 8 years ago · 2 comments

I got the following example

package main

import (
	"github.com/clbanning/mxj"
	"encoding/json"
	"fmt"
	"bytes"
)

func main() {
	var data = `{"lastname":"Mustermann","phone": null}"`

	mxj.JsonUseNumber = true
	var x interface{}
	dec := json.NewDecoder(bytes.NewReader([]byte(data)))
	dec.UseNumber()
	if err := dec.Decode(&x); err != nil {
		fmt.Printf("Unmarshal: %v", err)
	}
	xx, err := mxj.AnyXmlIndent(x, "", " ", "body")
	if err != nil {
		fmt.Println(err)
	}
	fmt.Println(string(xx))

}

Expected result is an empty phone element

<body>
 <lastname>Mustermann</lastname>
<phone/>
</body>

This is working in commit 1db1a88

but broken from commit adfeeb9

From this commit up to current master, we got this result

<body>
 <lastname>Mustermann</lastname>
<phone
</body>

Answer 1 · 2017-02-01T13:42:15.000Z

Fixed on tip.

Answer 2 · 2017-02-02T07:49:52.000Z

Wow, thx, quick fix. Now it is working.