Doubles only?

Question

Doubles only?

culurciello opened this issue 10 years ago · 7 comments

culurciello commented 10 years ago

Is there a reason why the algorithm only works on doubles?

lvdmaaten commented 9 years ago

Agreed!

Answer 1 · 2015-02-23T17:06:08.000Z

Hmmm, not really I guess. You want to be able to use floats as well? I'll work on that...

Answer 2 · 2015-02-23T19:02:52.000Z

I tried to pass floats and the results were incorrect. Did you try or did I make a mistake?

Answer 3 · 2015-02-23T19:43:33.000Z

I also get incorrect results when I pass floats, so I don't think it's your mistake.

Answer 4 · 2015-07-31T20:27:43.000Z

Hi Laurens van der Maaten, do you still have a plan to used Floats, or should we look into it?

Answer 5 · 2015-08-08T14:36:27.000Z

Hmmm changing the Torch code is easy, but this also requires changing the C++ code, which will imply a bit more work. I'm not sure I will have time for it anytime soon.

If you want to do it yourself, then start from this version: #4

Answer 6 · 2015-11-20T19:20:28.000Z

Ran into this issue as well and did some investigation to find the root cause, then came here to Github to file an issue and found this.

I could take a stab at making this change, but I think an immediate and simple change would be to just check the tensor type and throw an informative error, right than having the code segfault.