The ignore option for @clerk/upgrade is ignored
tmcw opened this issue · 8 comments
Preliminary Checks
-
I have reviewed the documentation: https://clerk.com/docs
-
I have searched for existing issues: https://github.com/clerk/javascript/issues
-
I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
-
This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.
Reproduction
Publishable key
pk_this_is_not_relevant
Description
Steps to reproduce:
- Run
npx @clerk/upgrade - Try ignoring a folder
Expected behavior:
It ignores the folder
Actual behavior:
It doesn't:
CleanShot.2024-04-22.at.09.35.31.mp4
Environment
System:
OS: macOS 14.4.1
CPU: (8) arm64 Apple M2
Memory: 339.13 MB / 24.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.9.0 - ~/.volta/tools/image/node/20.9.0/bin/node
Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
npm: 10.1.0 - ~/.volta/tools/image/node/20.9.0/bin/npm
pnpm: 9.0.3 - ~/Library/pnpm/pnpm
bun: 1.0.28 - ~/.bun/bin/bun
Watchman: 2024.04.15.00 - /opt/homebrew/bin/watchman
Browsers:
Chrome: 124.0.6367.61
Chrome Canary: 126.0.6433.0
Safari: 17.4.1
npmPackages:
@clerk/backend: ^1.0.0 => 1.0.0
@clerk/clerk-sdk-node: ^5.0.0 => 5.0.0
@clerk/remix: ^4.0.0 => 4.0.0Thanks for the issue! I can reproduce it locally and will work on a fix 👍
Ok, so I pushed 5546a3c - the gist of it is:
One needs to use **/public/** to correctly ignore the folder. I looked at the docs of the library we're using a bit but it wasn't immediately clear to me how to "fix" this (to allow public/**).
I tried https://github.com/mrmlnc/fast-glob#basenamematch but that didn't work 🤷 Prepending **/ to everything a user enters feels dangerous as it might result in unexpected behavior.
My change isn't released yet, once that's done I'll close this
The fix is published now 👍