clevertech/YiiBooster

Datepicker is showing underneath the modal

Closed this issue · 10 comments

this is the fix that they've provided for bootstrap-datepicker.js
uxsolutions/bootstrap-datepicker#609

what booster version?

@amrbedair Looks like the problem is present in v4.0.1

they did not release the bug fix yet ... so I will consider it in the next release
Thanks.

@amrbedair just FYI - it looks like there are numerous similar issues (and proposed fixes) they've had open for a while and the maintainer seems to be absent - an interim patch may not be out of the question...

@PrplHaz4 what issues you mentioned that is open for a while ... I am the maintainer ... and I am currently dedicated for this project ... but I do not know what issues you are talking about!?

btw: this is an open source project, and anyone can share on it

@amrbedair he was pertaining on the maintainer in javascript repository :) not you
https://github.com/eternicode
would it be possible to get the other forks?

sure if is better maintained ... do you have a recommendation?

sorry @amrbedair, I was referring to the issues that have been open for a long time on eternicode/bootstrap-datepicker. It also looks like there is no clear answer for a stable/maintained fork (and the github network graph for that repo is a nightmare!):
uxsolutions/bootstrap-datepicker#963

I think there are some problems with this approach and cannot properly test to find out, so haven't submitted a PR, but for the record, we are using the patch here: https://github.com/Zweer/bootstrap-datepicker/commit/a54c91f83e4a4ed027545bde3493a05e5dc30876

On a similar note, it seems that the current version of bootstrap-datepicker is 1.3.0, which adds bs3 support (I think YiiBooster uses 1.2.0) - but still does not include a fix for this issue...

It doesn't look like there's a simple path forward - so probably just something to keep in mind for the next release (as you've already stated).

Thanks for all the work on this library @amrbedair - it is very much appreciated!

as the 1.4 release has been late for a long time,
I have decided to use the master branch to include many bug fixes facing booster's users