client9/shlib

github_release always returns 0, even if release doesn't exist

client9 opened this issue · 1 comments

$ . ./is_command.sh 
$ . ./log.sh
$ . ./http_download.sh 
$ . ./github_release.sh 
$ github_release client9/misspell
v0.3.4
$ echo $?
0
# correct ^^

# non existant version number
$ github_release client9/misspell xxx
curl: (22) The requested URL returned error: 404 Not Found
$ echo $?
0

# this repo doesn't have any releases
$ github_release client9/shlib
curl: (22) The requested URL returned error: 406 Not Acceptable
$ echo $?
0

fixed