V17 | Padding Issue

Question

V17 | Padding Issue

mBilG opened this issue 3 years ago · 10 comments

Thanks for the amazing extension.

Just updated to the latest version (17).
Noticed 2 issues with padding (issue not present in previous version):

Player icons are too small (probably due to larger padding).
Title appears to be bottom-aligned: text gets cut-off when letters go below the line (g/y/q/p etc).

I'm using a different shell theme. However, even if i change to adwaita, the buttons still appear smaller than the rest of the icons.

Answer 1 · 2021-09-14T19:26:01.000Z

Thanks for reporting the issue.
Can you send me a screenshot and the name of your theme? I tested it on Pop theme, Materia theme, Orchis theme and the White Sur theme but the issue didn't exist.

Answer 2 · 2021-09-14T21:13:17.000Z

Hi, I figured out the issue and commited the fix.
To apply the fix you can use this command,
cd ~/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/ && curl -OL https://raw.githubusercontent.com/cliffniff/media-controls/main/player.js

Answer 3 · 2021-09-15T01:45:20.000Z

I'm currently using Fluent_compact theme by Vinceliuice.
I set my panel size to 26 px.
The icons appear bigger now, but still tiny compared to other icons (and previous version)

This is before applying fix:

This is after fix mentioned above:

This is from v14:

Maybe you need to remove top and bottom paddings/margins and let the theme control that?

Answer 4 · 2021-09-15T02:07:38.000Z

Maybe you need to remove top and bottom paddings/margins and let the theme control that?

Yes, that's what I did. In v14, all the elements were on the panel on their own. Now they are in a separate container. I'll find a workaround for this.

Answer 5 · 2021-09-15T02:17:57.000Z

I installed the theme and tested it on my machine and it shows the icons fine.

Answer 6 · 2021-09-15T02:28:11.000Z

I found a fix:

I use this for the buttons' style:

style: "padding: 0px 2px; margin: 0px 2px;"

Here's the result:

Answer 7 · 2021-09-15T02:38:57.000Z

I think it is a issue specific to the theme. The weird thing is it looks fine in the same theme when I installed it.

Answer 8 · 2021-09-15T03:00:03.000Z

Yes, that's what I did. In v14, all the elements were on the panel on their own. Now they are in a separate container. I'll find a workaround for this.

Maybe the padding/margin of the container also needs to be adjusted?

I think it is a issue specific to the theme. The weird thing is it looks fine in the same theme when I installed it.

I also noticed that the player icon has the same bug. I don't usually use the icon though, so i disabled it.

Just tested, I think the issue is caused when using "Just perfection" extension and setting my panel size to lower than 30px.

Panel 26px:

Panel 32px:

Answer 9 · 2021-09-15T16:15:28.000Z

Fixed the bug properly. Rerun the command cd ~/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/ && curl -OL https://raw.githubusercontent.com/cliffniff/media-controls/main/player.js && curl -OL https://raw.githubusercontent.com/cliffniff/media-controls/main/stylesheet.css to apply it. Thanks for reporting!

Edit: Updated the command.

Answer 10 · 2021-09-16T03:25:16.000Z

Excellent.. Works like a charm..
Thanks for your help and for the great extension.. keep it up..