Item Id values are crossing the max Int value
porterchris opened this issue · 7 comments
I'm new to using the Monday API, but I just started seeing errors in item Id values coming across the graph calls. I suspect that Monday uses a singular item counter even across different boards and workspaces. I created 2 items in completely different workspaces with different owners and the item values seem to be incrementing from the same list. Both values were above 2,147,483,647 and in less than 15 minutes there were about 70,000 numbers apart.
If my theory is accurate, all usages of this library will have stopped working when any new items are being parsed as of about 8 hours ago.
This code needs to be an int64 or long.
It looks like this is a confirmed issue and also applies to board IDs: https://community.monday.com/t/board-ids-are-now-too-big-for-an-integer-check-your-databases-and-update-your-apps/29844
I don't know if this repository is still maintained. However, it looks like @jonaramos (https://github.com/jonaramos/Monday.NetCore) wants to continue the development of this library.
Expect a new release today. I've been down with the sickness this week.
I did the PR for int(32) to long. I considered going string. I believe that Monday.com's recommendation is for string but that brings in some other concerns in a strongly typed language. String probably is a more appropriate direction as long as the inputs for methods are handling non-numeric values cleanly. My general rule has been that if you aren't doing math or incrementing the value, numerics should probably be strings (phone numbers and postal codes). One could argue that the values are incremented, but that is done 100% by Monday.com and these libraries serve only to access the data, not control the increment.
@porterchris your pull request has been merged. Regarding Monday, the way the handle their data is odd in itself and it was the right call to use long.