clj-commons/clj-http-lite

dev cleanup: consider bumping ancient ring-jetty-adapter used for tests

lread opened this issue · 0 comments

lread commented

Currently

We use v1.3.2 of the ring-jetty-adapter to help support testing.
It is used to fire up a jetty server for integration tests.
It brings in Jetty v7 which was retired in 2014.

I avoided bumping this with other deps because it requires changes to our test code.

Diagnosis

I had a peek and the code changes are minor.

Current ring-jetty-adapter brings in Jetty v9 (which is also long in the tooth and has started to sunset).

Proposal

Bump.

I believe that keeping up with current versions of libs can be helpful when devs try to make sense of the code base (and 3rd party docs).

Next Steps

I expect none will object, but please do pipe in if you have any concerns.
I shall submit a PR.