tests: server-name should not include port
lread opened this issue · 0 comments
lread commented
I happened to notice...
That our current integration tests include the port in the :server-name
:
clj-http-lite/test/clj_http/test/core_test.clj
Lines 84 to 86 in 0219dc9
But this is because...
The we expect :server-port
, and not as we see above :port
.
clj-http-lite/src/clj_http/lite/core.clj
Lines 67 to 73 in 0219dc9
Soo...
I'll fix that up. It happens to work, but it is not proper usage and misleading to anyone reading our tests.